-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stack setup for GHC 9.2.8 #2531
Conversation
Apparently Hydra does not like the new |
8ad7aae
to
6503017
Compare
Ok, I think the issue with Hydra is the last missing thing here - but as already mentioned I don't know how to fix that on my own. Pinging @Gabriella439 , since she probably knows the setup best. As a side note, I think this work here supersedes the one in #2428 (which I discovered too late). Also, if we merge this we should adjust the required status checks for the main branch to match the new names of the jobs. |
ah, whoops, it's because of this issue: https://hydra.dhall-lang.org/jobset/dhall-haskell/2531#tabs-errors
If you do |
@mmhat There was a possible solution suggested by @Gabriella439, did you investigate if it solves the issue, so this PR can be merged? Also, this PR doesn't fully address the tests, where lsp-test < 0.15 is specified (0.16 is the newest version). Have you looked at that? Else I'd do that. |
- dhall-lsp-server: Require lsp>=1.5.0.0.
@Vekhir Thanks for the ping! I think lsp-test < 0.15 is fine: All lsp-test version that are newer require lsp >= 2.0 which we exclude in our version constraints; IMHO we should relax the lsp-test upper bound once we moved to lsp >= 2.0. @Gabriella439 Thanks a lot for the hint; That totally worked out! I took the liberty to merge the branch and adjust the required GitHub status checks accordingly. I also deleted the stale Travis CI webhook that didn't work anyway. |
* Bumped Stack snapshot to LTS 18.28 - dhall-lsp-server: Require lsp>=1.5.0.0. * Updated GitHub Actions * Added Stack configuration for GHC 9.2.8 * Added CI job for GHC 8.10 * Allow passing extra arguments to the doctest test suites * Cabal: Use hnix from Git repository * Use single quotes in GHA condition * GHA: Try nested os.runner * GHA: Include used stack.yaml file in job name * Updated mergify config * Also skip package preparation step if we are not using stack.yaml * Updated used actions * Added text-rope.nix * Added co-log-core.nix and lsp.nix * Added lsp-types.nix
This PR adds a
stack.yaml
for LTS 20, i.e. GHC 9.2.8. This one is now used by default but we run an additional CI job with the LTS 18 setup to ensure that Dhall builds for both GHCs. Additional changes:Dhall.Syntax.Expr
in order to fix doctests.